Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed corpus_raw_is_routed) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er platform jobs (storytold#901); gap 9 shrinks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robmdunn
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small additions related to #989 that no other open PR covers (the rest of #989 is in #990, #994, #997, #1003, #1007, #1018 and #1052).
.github/workflows/macos.ymlrunscargo xtask cionmacos-15. Every macOS break in main does not build or pass its tests on macOS (995d5ea4): app won't compile, 12 tests fail, one clippy lint #989 got through because no workflow builds or tests on macOS:cfg(target_os = "macos")code (the native menu, Apple Photos export) and APFS behaviour (case-insensitive, UTF-8-only names) are invisible to the Linux and FreeBSD jobs.main(51 4 * * *, staggered from FreeBSD and Windows ARM64), on pushes torelease, by hand, and on PRs that change this workflow. That's not per PR: a macOS break shows up within a day and always before a release, without adding a slow macOS job to every PR on shared runners. Whether to run it per PR is the maintainers' call (see ci: add Linux x64 CI workflow (partially closes gap #9) #941).maindoesn't build on macOS yet: it currently stops at clippy (Issue #989: clippy 1.99, fill_box reads its buffer with as_chunks::<3>() (item 4) #997), then at theon_exitbuild error (Issue #989: the lock test finds true on the PATH #990 / Fix macOS build: menu-bar Quit no longer calls eframe's on_exit #994).docs/gaps.md: macOS is no longer listed as untested, and Windows x64 and Linux x64 remain (6–12 h → 4–8 h). The stability row indocs/target-app-parity.mdand item 8 inROADMAP.mdfollow, with revision-history entries. Headline numbers are unchanged.corpus_raw_is_routedasserts that every file undercorpus/raw/sniffs as a raw. Finder writes a.DS_Storeinto any folder it opens, which then failed the test (sniffed None). Hidden files (.DS_Store,._*AppleDouble files) are now skipped. This only affects machines with a local corpus.Checked on macOS 27 / Rust 1.99:
cargo test -p lightcraft-codecs --features heif --test corpuspasses with a.DS_Storeincorpus/raw/;cargo fmt --checkis clean;cargo xtask paritypasses.Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com